-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(notifications): added notifications #176
feat(notifications): added notifications #176
Conversation
4c80464
to
ab69324
Compare
@@ -1,6 +1,6 @@ | |||
import { Query } from '$lib/api/executor.js' | |||
import { useStripeCtx } from '$lib/ctx/stripe/index.js' | |||
import { notifcation } from '$ui/core/Notifications/index.js' | |||
import { notification } from '$ui/core/Notifications/index.js' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed typo in notification
object
e2c1e6f
to
a9c708f
Compare
8b83c53
to
4a5fd47
Compare
4a5fd47
to
0282bf0
Compare
message: string, | ||
options?: Omit<ComponentProps<Component>, 'icon' | 'message'>, | ||
) { | ||
return toast.custom(Component as unknown as ComponentType, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to do this because of the different types of components in Svelte 4 and Svelte 5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error I encountered when trying to pass a component without type conversion:
Argument of type '__sveltets_2_IsomorphicComponent<Props, { closeToast: CustomEvent<any>; } & { [evt: string]: CustomEvent<any>; }, {}, {}, "">' is not assignable to parameter of type 'ComponentType'.
Type '__sveltets_2_IsomorphicComponent<Props, { closeToast: CustomEvent<any>; } & { [evt: string]: CustomEvent<any>; }, {}, {}, "">' is not assignable to type 'new (options: ComponentConstructorOptions<Record<string, any>>) => SvelteComponent<Record<string, any>, any, any>'.
Types of parameters 'options' and 'options' are incompatible.
Type 'ComponentConstructorOptions<Record<string, any>>' is not assignable to type 'ComponentConstructorOptions<Props>'.
Type 'Record<string, any>' is missing the following properties from type 'Props': icon, messagets(2345)
src/lib/ui/core/Dialog/vaul.ts
Outdated
export const getVaulCtx = (ctx = getAllContexts()): [] | [Symbol, any] => | ||
Array.from(ctx.entries()).find(([key, value]) => value?.states?.drawerId) || [] | ||
export const getVaulCtx = (ctx = getAllContexts()): [] | [symbol, any] => | ||
Array.from(ctx.entries()).find(([_key, value]) => value?.states?.drawerId) || [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was changed because eslint error. Symbol
letter case changed automatically by eslint --fix
@@ -1 +1 @@ | |||
export { default } from './InsightCard.svelte'; | |||
export { default } from './InsightCard.svelte' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was hanged automatically by eslint --fix
e6ece4b
to
7beab05
Compare
7beab05
to
db8dcf3
Compare
…te-5-san-webkit-next
…te-5-san-webkit-next
…on ui in storybook
Summary
Added notifications
Notion card
New design
Old one
Screenshots